Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi entity spawn #146

Merged
merged 2 commits into from
May 20, 2020
Merged

Support multi entity spawn #146

merged 2 commits into from
May 20, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 20, 2020

Support multi-entity spawn.

Requires: gazebosim/gz-msgs#58

Signed-off-by: Nate Koenig nate@openrobotics.org

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from azeey May 20, 2020 02:06
@nkoenig nkoenig requested a review from chapulina as a code owner May 20, 2020 02:06
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #146 into ign-gazebo2 will decrease coverage by 8.64%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo2     #146      +/-   ##
===============================================
- Coverage        62.42%   53.78%   -8.65%     
===============================================
  Files              123      121       -2     
  Lines             6087     5838     -249     
===============================================
- Hits              3800     3140     -660     
- Misses            2287     2698     +411     
Impacted Files Coverage Δ
...lude/ignition/gazebo/components/PerformerLevels.hh 8.33% <0.00%> (-91.67%) ⬇️
...ude/ignition/gazebo/components/LevelEntityNames.hh 8.33% <0.00%> (-91.67%) ⬇️
include/ignition/gazebo/components/JointType.hh 12.50% <0.00%> (-87.50%) ⬇️
...lude/ignition/gazebo/components/DetachableJoint.hh 12.50% <0.00%> (-87.50%) ⬇️
...nclude/ignition/gazebo/components/Serialization.hh 0.00% <0.00%> (-76.00%) ⬇️
src/Link.cc 12.37% <0.00%> (-67.02%) ⬇️
src/Model.cc 41.37% <0.00%> (-58.63%) ⬇️
src/LevelManager.cc 41.61% <0.00%> (-49.11%) ⬇️
src/network/NetworkManagerSecondary.cc 59.67% <0.00%> (-20.97%) ⬇️
src/network/NetworkManager.cc 62.16% <0.00%> (-18.92%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebdf5e...0c8ea26. Read the comment docs.

@nkoenig nkoenig mentioned this pull request May 20, 2020
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nkoenig nkoenig merged commit 59a479c into ign-gazebo2 May 20, 2020
@nkoenig nkoenig deleted the multi_entity branch May 20, 2020 13:03
nkoenig added a commit that referenced this pull request May 21, 2020
* Add shapes plugin (#107)

Signed-off-by: John Shepherd <john@openrobotics.org>

* Add option to suppress warning about missing child model (#132)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* Support multi entity spawn (#146)

* Support multi entity spawn

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added more documentation

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>

* Bump ign-msgs version to 4.9 (#148)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Revert silly mistake

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* ign-msgs 5.3 dependency

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Bump minor version

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Changelog

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* RawPose

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: John <john@openrobotics.org>
Co-authored-by: Addisu Taddese <addisu@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
azeey pushed a commit to azeey/gz-sim that referenced this pull request May 28, 2020
* Support multi entity spawn

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added more documentation

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants